Skip to content

fix(tracing): reject zero batch sizes - #4569

Closed
hsusul wants to merge 1 commit into
openai:mainfrom
hsusul:fix/batch-trace-zero-batch-size
Closed

fix(tracing): reject zero batch sizes#4569
hsusul wants to merge 1 commit into
openai:mainfrom
hsusul:fix/batch-trace-zero-batch-size

Conversation

@hsusul

@hsusul hsusul commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reject max_batch_size=0 during BatchTraceProcessor construction
  • prevent force_flush from silently leaving queued spans unexported

Test plan

  • UV_CACHE_DIR=/tmp/uv-pr6-b uv run pytest tests/test_trace_processor.py -q (58 passed)
  • changed-file Pyright and mypy
  • full suite: 9031 passed, 39 skipped; 38 environment-restricted failures (forkserver/native macOS sandbox)

Issue number

N/A

Checks

  • Focused regression tests added
  • git diff --check clean

@seratch

seratch commented Aug 21, 2026

Copy link
Copy Markdown
Member

We'd like to hold off adding this type of obvious value error validation for now.

@seratch seratch closed this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants