fix(models): reject non-finite Retry-After delays - #4558
Closed
sylvesterkaczmarek wants to merge 2 commits into
Closed
fix(models): reject non-finite Retry-After delays#4558sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request prevents malformed provider retry headers from producing an infinite runner-managed retry delay.
parse_retry_after_ms()and the numeric branch ofparse_retry_after_value()now require parsed delays to be both finite and non-negative. Values such asInfinity,-Infinity, andNaNtherefore returnNoneinstead of propagating into retry advice and potentially reachingasyncio.sleep()as an unbounded delay.All valid finite
Retry-AfterandRetry-After-Msvalues retain their current behavior, including HTTP-date parsing. Focused regression coverage checks the non-finite forms for both numeric header formats and finite control values.This pull request resolves #4555.