-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: make sensitive trace payloads opt-in by default #4550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
58d0721
68a22bc
5475fb2
8c5cdcb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,9 +23,10 @@ class VoicePipelineConfig: | |
| tracing: TracingConfig | None = None | ||
| """Tracing configuration for this pipeline.""" | ||
|
|
||
| trace_include_sensitive_data: bool = True | ||
| """Whether to include sensitive data in traces. Defaults to `True`. This is specifically for the | ||
| voice pipeline, and not for anything that goes on inside your Workflow.""" | ||
| trace_include_sensitive_data: bool = False | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When static analysis is active, the handwritten AGENTS.md reference: AGENTS.md:L100-L100 Useful? React with 👍 / 👎. |
||
| """Whether to include sensitive data in traces. Defaults to `False` for security. When enabled, | ||
| tool inputs/outputs and LLM generations may be exposed in traces. Only enable in trusted | ||
| environments.""" | ||
|
|
||
| trace_include_sensitive_audio_data: bool = True | ||
| """Whether to include audio data in traces. Defaults to `True`.""" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line documents the new opt-in default introduced by the accompanying runtime change, so it is not accurate for the latest published package until that behavior is released. Repository policy requires documentation for unreleased behavior to be handled in a separate docs-only pull request coordinated with the release; remove this documentation change from the runtime fix.
AGENTS.md reference: AGENTS.md:L76-L78
Useful? React with 👍 / 👎.