fix(core): fail closed on empty tool arguments - #4545
Merged
seratch merged 1 commit intoAug 20, 2026
Conversation
Missing or blank argument strings were coerced to {} before callable
needs_approval ran, so content gates could skip interruption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request treats missing or blank function-tool argument strings as uninspectable for callable
needs_approvalpolicies.parse_function_tool_argumentspreviously usedarguments or \"{}\", so\"\"andNonebecame an empty object. A content gate such as\"refund\" in params.get(\"subject\", \"\")then returnedFalseand the tool ran without interruption. Invalid JSON already failed closed after #3867; empty/missing argument strings now do the same. An explicit\"{}\"payload is still a valid empty object.The same helper is used by Runner tool execution and Realtime session tool calls.
Test plan
uv run pytest -q tests/test_hitl_error_scenarios.py::test_callable_function_approval_fails_closed_for_invalid_arguments tests/realtime/test_session.py::TestToolCallExecution::test_callable_function_approval_fails_closed_for_invalid_argumentsmake format && make lint && make typecheckIssue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR