fix(extensions): nest extra_body on the any-llm chat path - #4544
Merged
Conversation
Flattening extra_body into acompletion kwargs collided with named parameters such as temperature and diverged from the Responses and LiteLLM adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request nests
ModelSettings.extra_bodyon the AnyLLM chat Completions path instead of flattening it into top-levelacompletionkwargs.The Responses path and LiteLLM already copy
extra_bodyunderextra_body. The chat helper merged the mapping into kwargs, so provider fields such ascached_contentbecame top-level arguments and a nestedtemperaturecollided with the explicittemperature=parameter (TypeError: got multiple values for keyword argument 'temperature'). Emptyextra_queryandmetadatamappings are now forwarded when set, matching the Responses helper.extra_argsstill flatten as top-level kwargs.Test plan
uv run pytest -q tests/models/test_any_llm_model.pymake format && make lint && make typechecktemperatureIssue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR