fix(visualization): keep fillcolor on handoff nodes by merging style attributes#3744
Merged
Merged
Conversation
seratch
approved these changes
Jul 7, 2026
seratch
left a comment
Member
There was a problem hiding this comment.
Thanks. This is indeed a nice improvement 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handoff and sub-agent nodes in the agent visualization are meant to render as filled
lightyellowboxes (matching the root agent node), but they currently render as empty/unfilled boxes.The node attribute list sets
styletwice:style=filled, style=rounded. In the DOT language a repeated attribute takes the last value, sostyleresolves toroundedonly andfilledis dropped. Becausefillcoloronly takes effect whenfilledis present instyle, thefillcolor=lightyellowwas silently ignored.This merges the two into a single valid value,
style="filled,rounded", so the nodes are both filled and rounded as intended. Applies to both theHandoffandAgenthandoff branches inget_all_nodes.Test plan
Verified against the actual Graphviz renderer (
dot) by rendering a node both ways to SVG and inspecting the node polygon fill:style=filled, style=rounded) ->fill="none"(unfilled)style="filled,rounded") ->fill="lightyellow"(filled, as intended)Updated the existing
tests/test_visualization.pyexpectations (which asserted the old DOT string) to match the corrected output. Ran the standard checks:uv run ruff format --check— passuv run ruff check— passuv run mypy src/agents/extensions/visualization.py— passuv run pytest tests/test_visualization.py— 10 passedIssue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh(ran the equivalent stack manually: ruff format/check, mypy, pytest — see test plan)/reviewbefore submitting this PR — N/A