fix: filter hosted_tool_call types in remove_all_tools handoff filter#3386
Open
ioleksiuk wants to merge 1 commit into
Open
fix: filter hosted_tool_call types in remove_all_tools handoff filter#3386ioleksiuk wants to merge 1 commit into
ioleksiuk wants to merge 1 commit into
Conversation
Extend the fix in openai#3095 to cover one more raw input item type that the handoff filter was missing. `hosted_tool_call` is a real tool-call type recognized elsewhere in the SDK — see `src/agents/run_state.py:2024` (raw item normalization) and `src/agents/run_internal/tool_execution.py:2368` (hosted MCP approval request detection, which checks for `type == "hosted_tool_call"` plus `provider_data.type == "mcp_approval_request"`). However, the `_remove_tool_types_from_input` filter in `src/agents/extensions/handoff_filters.py` did not include it, so raw `hosted_tool_call` items survived `remove_all_tools` handoff filtering. Add `hosted_tool_call` to the filter list and to the parametrized list in the existing `test_removes_hosted_tool_types_from_input_history` regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the fix in #3095 to cover one more raw input item type that the handoff filter was missing.
`hosted_tool_call` is a real tool-call item type recognized elsewhere in the SDK:
However, `_remove_tool_types_from_input` in `src/agents/extensions/handoff_filters.py` did not include `hosted_tool_call` in its filter list. Raw `hosted_tool_call` items in `input_history` therefore survived `remove_all_tools` handoff filtering — leaking provider-level tool-call payloads (including hosted MCP approval requests in the raw `hosted_tool_call` form) into the downstream agent's history.
Add `hosted_tool_call` to the filter list and extend the parametrized list in the existing `test_removes_hosted_tool_types_from_input_history` regression test.
Test plan
Issue number
N/A — found while auditing for the same gap that #3095 fixed for `custom_tool_call`.
Checks