fix: avoid mutating codex output schema input#3385
Open
ioleksiuk wants to merge 1 commit into
Open
Conversation
Mirror the MCP fix in openai#3134 (and the FunctionTool fix in openai#3382) for the Codex output_schema path. `_resolve_output_schema` currently does `schema = dict(option)`, which is only a shallow copy — nested user dicts (e.g. each entry in `option["properties"]`) are the same identity as the caller's. `ensure_strict_json_schema` then mutates those nested dicts in place (it is documented as mutating its input), leaking strict-mode side effects like `additionalProperties: false` and `required: [...]` back into the caller's stored schema. Switch to `copy.deepcopy(dict(option))` so the strict conversion only mutates the local copy, matching the precedent established by openai#3134.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the MCP fix in #3134 (and the `FunctionTool` fix in #3382) for the Codex `output_schema` path. `_resolve_output_schema` in `src/agents/extensions/experimental/codex/codex_tool.py:696-700` does `schema = dict(option)`, which is only a shallow copy — nested user dicts (e.g. entries in `option["properties"]`) are the same identity as the caller's. `ensure_strict_json_schema` (documented as mutating its input at `src/agents/strict_schema.py:20`) then mutates those nested dicts in place, leaking strict-mode side effects like `additionalProperties: false` and `required: [...]` back into the caller's stored schema.
```python
Switch to `copy.deepcopy(dict(option))` so the strict conversion only mutates the local copy, matching the precedent established by #3134 in MCP and #3382 in `FunctionTool`.
Test plan
Issue number
N/A — found while auditing for the same mutation-aliasing pattern that #3134 and #3382 fixed.
Checks