fix: #3354 interrupt tracing retry backoff on shutdown#3355
Open
Aphroq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3343: finite-timeout tracing shutdown now requests the OpenAI tracing exporter to stop retry backoff that was already in progress before shutdown started.
This lets
BatchTraceProcessor.shutdown(timeout=...)wake a 5xx retry sleep and finish cleanup promptly instead of waiting for the timeout and returning with the worker still alive.shutdown(timeout=None)still preserves the existing full retry behavior.The atexit subprocess regression now runs as a serial test and asserts the child process's measured shutdown duration, avoiding xdist wall-clock contention while still checking that the original exit code is preserved.
Test plan
uv run pytest tests/test_trace_processor.py::test_batch_trace_processor_shutdown_interrupts_exporter_retry_backoff tests/test_trace_processor.py::test_batch_trace_processor_shutdown_without_timeout_preserves_export_retries tests/test_trace_processor.py::test_tracing_atexit_cleanup_timeout_preserves_process_exit_code_on_504 -quv run pytest tests/test_trace_processor.py -quv run pytest -n auto --dist loadfile -m "not serial" tests/test_trace_processor.py -quv run pytest -m serial tests/test_trace_processor.py::test_tracing_atexit_cleanup_timeout_preserves_process_exit_code_on_504 -qbash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3354
Checks
make lintandmake format