fix: #3346 clean up branch-only messages when deleting branches#3347
Open
Aphroq wants to merge 1 commit into
Open
fix: #3346 clean up branch-only messages when deleting branches#3347Aphroq wants to merge 1 commit into
Aphroq wants to merge 1 commit into
Conversation
c36a54e to
5732480
Compare
Contributor
Author
|
Pushed follow-up commit to the PR branch with two extra boundary hardenings:
|
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes
AdvancedSQLiteSession.delete_branch()leaving branch-only message rows behind after deleting a branch. After removing the deleted branch'smessage_structurerows, the method now cleans up message rows for the current session that are no longer referenced by any structure row, using the same lock and transaction while preserving messages still shared by main or other branches.Test plan
uv run pytest -q tests/extensions/memory/test_advanced_sqlite_session.py::test_delete_branch_removes_branch_only_messages tests/extensions/memory/test_advanced_sqlite_session.py::test_branching_functionality tests/extensions/memory/test_advanced_sqlite_session.py::test_branch_deletion_with_forceuv run pytest -q tests/extensions/memory/test_advanced_sqlite_session.pybash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3346
Checks
make lintandmake format