Merged
Conversation
509b2cc to
3710e66
Compare
3710e66 to
e83f734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.8.0 -> TARGET e83f734)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.8.0...e83f734
Release call:
🟢 GREEN LIGHT TO SHIP Changes are scoped and fixes are covered by targeted tests; no confirmed breaking regressions detected.
Scope summary:
src/agents/extensions/experimental/codex/,src/agents/run_state.py,src/agents/run_internal/run_loop.py, tests, examples, and docs.Risk assessment (ordered by impact):
Codex tool name restrictions may reject previously accepted names
codex_toolwith non-codex/codex_names will now receive aUserErrorduring tool creation._resolve_codex_tool_nameenforcescodexorcodex_prefix and validates suffixes insrc/agents/extensions/experimental/codex/codex_tool.py.src/agents/extensions/experimental/codex/codex_tool.pyuv run pytest -k codex_tooland confirm all codex-tool tests pass; if failures arise, document the naming constraint in release notes or adjust migration guidance.Duplicate Codex tool names now error at tool resolution
UserError._validate_codex_tool_name_collisionsadded and invoked during tool resolution insrc/agents/agent.py.src/agents/agent.pyuv run pytest -k codex_tooland ensure no failures; verify any multi-codex tool example/docs use unique names.Run-state and streamed run-again persistence changes
src/agents/run_state.pyand new streamed run-again item persistence insrc/agents/run_internal/run_loop.py.src/agents/run_state.py,src/agents/run_internal/run_loop.py,tests/test_run_state.py,tests/test_agent_runner_streamed.pyuv run pytest -k "run_state or agent_runner_streamed"and confirm tests pass.Notes:
v0.8.0. TARGET is current HEADe83f7347b21576c58e357a81f725cf4d0bce69e2.$code-change-verificationcoverage.