bazel: materialize configured test shards#31455
Draft
anp-oai wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows Bazel profiling in #31339 and #31367 showed that heavy sharded Rust test labels still form the long pole because GitHub assigns the entire Bazel label to one runner. For example,
core-all-test-windows-crosskeeps all 16 internal test shards on one host, where most critical-path time is spent waiting for local test resources.Materializing configured test shards as first-class Bazel targets lets the existing GitHub target selection distribute those shards across Windows runners while preserving the current canonical labels for local use.
What
test_shard_countsentry generate oneworkspace_root_testleaf per stable libtest buckettest_suiteover those leavesshard_countManual validation
bazel query 'tests(//codex-rs/core:core-all-test-windows-cross)' --output=labelreturns 16 shard targetsbazel test //codex-rs/exec:exec-all-test-shard-1-of-8 --test_output=errorsbazel test //codex-rs/exec:exec-all-test --test_output=errorsruns and passes all 8 suite membersjust argument-comment-lint