refactor: make ExternalAuth return CodexAuth by lt-oai · Pull Request #31355 · openai/codex

lt-oai · 2026-07-07T04:16:54Z

Summary

refactor ExternalAuth to return CodexAuth directly
remove the parallel ExternalAuthTokens wrapper
preserve existing external bearer and app-server refresh behavior

This is a mechanical precursor refactor; it does not add auth capabilities or change recovery behavior.

Testing

cargo fmt --all
cargo test -q -p codex-login --lib
cargo test -q -p codex-app-server --test all external_auth_refreshes_on_unauthorized

lt-oai · 2026-07-07T04:32:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 104087bdca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T05:44:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd99341185

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T05:55:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcb4958fca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T06:09:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 739a48c51b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T06:25:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f0c0016f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T06:41:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b78fb4e71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T06:52:37Z

@codex review

chatgpt-codex-connector · 2026-07-07T06:59:36Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: c226676ede

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c226676ede

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T07:57:04Z

@codex review

chatgpt-codex-connector · 2026-07-07T08:03:31Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: ac10d34cb6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T08:37:01Z

@codex review

chatgpt-codex-connector · 2026-07-07T08:40:45Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 1ba8f664b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lt-oai · 2026-07-07T08:45:20Z

@codex review

chatgpt-codex-connector · 2026-07-07T08:48:28Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: f28d829aa0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pakrym-oai · 2026-07-07T15:08:40Z

+/// auth on demand via `refresh()`.
 pub trait ExternalAuth: Send + Sync {
    /// Indicates which top-level auth mode this external provider supplies.
    fn auth_mode(&self) -> AuthMode;


can this be deleted?

pakrym-oai · 2026-07-07T15:15:02Z

            return Ok(());
        }
-        let Some(chatgpt_metadata) = refreshed.chatgpt_metadata() else {
+        if refreshed.api_auth_mode() != AuthMode::ChatgptAuthTokens {


do we need this enforcement?

Can we make all token types work on refresh?

Okay, I've read the code a bit more and it's very confusing. We push both types of auth through the same infra (ExternalAuth) but consume it through different paths.

The enforcement was because the old return type could only represent external ChatGPT tokens on this path; with CodexAuth, other variants are now representable, so the check keeps those out for now.

That split already existed: bearer auth uses resolve(), while app-server auth uses refresh() and ephemeral persistence. I kept that unchanged so the refactor only replaces ExternalAuthTokens with CodexAuth.

Let me know if we should pursue different direction!

github-actions Bot mentioned this pull request Jul 7, 2026

📊 AI CLI 工具社区动态日报 2026-07-07 litang9/big_model_radar#174

Open

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch 3 times, most recently from 038f72f to cd99341 Compare July 7, 2026 05:39

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from cd99341 to bcb4958 Compare July 7, 2026 05:54

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch 2 times, most recently from aa63fe0 to 739a48c Compare July 7, 2026 06:07

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs

Comment thread codex-rs/login/src/auth/manager.rs

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from 739a48c to 2f0c001 Compare July 7, 2026 06:24

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from 2f0c001 to 6b78fb4 Compare July 7, 2026 06:40

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from 6b78fb4 to c226676 Compare July 7, 2026 06:52

lt-oai marked this pull request as ready for review July 7, 2026 07:15

lt-oai assigned pakrym-oai Jul 7, 2026

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

Comment thread codex-rs/login/src/auth/manager.rs Outdated

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from c226676 to ac10d34 Compare July 7, 2026 07:55

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from ac10d34 to 1ba8f66 Compare July 7, 2026 08:35

refactor: make ExternalAuth return CodexAuth

f28d829

lt-oai force-pushed the codex/external-auth-codex-auth-precursor branch from 1ba8f66 to f28d829 Compare July 7, 2026 08:45

pakrym-oai reviewed Jul 7, 2026

View reviewed changes

pakrym-oai approved these changes Jul 7, 2026

View reviewed changes

pakrym-oai reviewed Jul 7, 2026

View reviewed changes

pakrym-oai mentioned this pull request Jul 7, 2026

refactor: unify external auth resolution #31421

Open

Uh oh!

Conversation

lt-oai commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

lt-oai commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

pakrym-oai Jul 7, 2026

lt-oai commented Jul 7, 2026 •

edited

Loading