feat(app-server): migrate remote control to server tokens#24141
Open
apanasenko-oai wants to merge 3 commits into
Open
feat(app-server): migrate remote control to server tokens#24141apanasenko-oai wants to merge 3 commits into
apanasenko-oai wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fd28a6f61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-backendnow authenticates remote-control server websocket connections with short-lived server tokens instead of the user's ChatGPT access token.app-serverneeds to mint and refresh those server tokens without persisting them, so a restart can reconnect from durable enrollment identity while keeping the bearer token memory-only.What Changed
Updated the remote-control transport to consume
remote_control_tokenandexpires_atfrom server enroll responses and added/server/refreshsupport for persisted enrollments or expiring cached tokens.Websocket handshakes now send
Authorization: Bearer <remote_control_token>with the existing server identity headers, and no longer send the ChatGPT bearer token orchatgpt-account-idon that websocket path.The in-memory enrollment state now owns the ephemeral server token cache, while SQLite still persists only
server_id,environment_id, andserver_name. Websocket401/403clears only the cached token for refresh on reconnect; websocket or refresh404clears stale persisted enrollment and re-enrolls. Response body previews redactremote_control_tokenbefore surfacing parse errors.Verification
Targeted remote-control transport coverage now exercises restart refresh, cached-token reconnects, websocket token invalidation, stale enrollment re-enrollment, and server-token handshake headers in
codex-app-server-transporttests.