centralize Responses retry policy#24131
Open
rhan-oai wants to merge 1 commit into
Open
Conversation
eecab42 to
c1cfb21
Compare
c1cfb21 to
96d3b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#23951 added remote compaction v2 retries, but it left the retry and WS -> HTTPS fallback behavior duplicated between normal Responses turns and compaction. This follow-up centralizes the common retry handling so future changes to fallback, retry delay, retry notifications, and retry sleep do not have to be kept in sync across both callsites.
What changed
core/src/responses_retry.rswith a shared handler for retryable Responses stream errors.stream_max_retries, while compaction v2 still usesmin(stream_max_retries, 2).The shared handler now owns:
Reconnecting... n/maxstream-error notificationVerification
cargo test -p codex-core remote_compact_v2cargo test -p codex-core websocket_fallbackjust fix -p codex-coreDid not run the full workspace test suite.