Skip to content

[codex] adjust apply_patch file replacement behavior#22212

Draft
bookholt-oai wants to merge 1 commit into
mainfrom
dev/bookholt/pr-22208
Draft

[codex] adjust apply_patch file replacement behavior#22212
bookholt-oai wants to merge 1 commit into
mainfrom
dev/bookholt/pr-22208

Conversation

@bookholt-oai
Copy link
Copy Markdown

@bookholt-oai bookholt-oai commented May 11, 2026

Summary

  • Normalize how apply_patch replaces pre-existing write targets before persisting new content.
  • Add regression coverage for replacement semantics in direct CLI and integration paths.
  • Keep the change scoped to write-path behavior and associated tests.

Validation

  • cargo test -p codex-apply-patch
  • cargo test -p codex-core --test all apply_patch_cli_does_not_write_through_symlink_escape_outside_workspace
  • just fmt
  • just fix -p codex-apply-patch

@github-actions
Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Normalize existing-target replacement before persisting new content.

Add focused regression coverage for the updated write-path behavior and keep the change scoped to the relevant integration boundary.

Co-authored-by: Codex <noreply@openai.com>
@bookholt-oai bookholt-oai force-pushed the dev/bookholt/pr-22208 branch from 400bac0 to 240d808 Compare May 11, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant