Skip to content

[codex] Stop Windows sandbox setup after filter installation failure#22211

Draft
bookholt-oai wants to merge 2 commits into
mainfrom
dev/bookholt/windows-sandbox-setup-errors
Draft

[codex] Stop Windows sandbox setup after filter installation failure#22211
bookholt-oai wants to merge 2 commits into
mainfrom
dev/bookholt/windows-sandbox-setup-errors

Conversation

@bookholt-oai
Copy link
Copy Markdown

What changed

  • Treat Windows sandbox filter installation failures as setup failures.
  • Preserve the existing logging and telemetry around filter installation.
  • Avoid reporting offline sandbox setup as successful when its required filter setup did not complete.

Validation

  • cargo test -p codex-windows-sandbox
  • cargo check -p codex-windows-sandbox --target x86_64-pc-windows-msvc attempted; blocked on this Linux host by missing MSVC tooling (lib.exe).
  • python3 tools/argument-comment-lint/run-prebuilt-linter.py attempted; blocked while compiling unrelated Linux sandbox support because libcap.pc is unavailable in this environment.

Treat filter installation failure as a setup failure instead of allowing offline sandbox initialization to continue.

Co-authored-by: Codex <noreply@openai.com>
@github-actions
Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Keep the fail-closed WFP setup path exercised for installer errors and panics.

Co-authored-by: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant