[codex] Stop Windows sandbox setup after filter installation failure#22211
Draft
bookholt-oai wants to merge 2 commits into
Draft
[codex] Stop Windows sandbox setup after filter installation failure#22211bookholt-oai wants to merge 2 commits into
bookholt-oai wants to merge 2 commits into
Conversation
Treat filter installation failure as a setup failure instead of allowing offline sandbox initialization to continue. Co-authored-by: Codex <noreply@openai.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Keep the fail-closed WFP setup path exercised for installer errors and panics. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validation
cargo test -p codex-windows-sandboxcargo check -p codex-windows-sandbox --target x86_64-pc-windows-msvcattempted; blocked on this Linux host by missing MSVC tooling (lib.exe).python3 tools/argument-comment-lint/run-prebuilt-linter.pyattempted; blocked while compiling unrelated Linux sandbox support becauselibcap.pcis unavailable in this environment.