test(app-server): run plain tests in process#22203
Draft
starr-openai wants to merge 1 commit into
Draft
Conversation
9a06773 to
d6773fc
Compare
4b79f87 to
3e68124
Compare
Co-authored-by: Codex <noreply@openai.com>
3e68124 to
509e267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppServerTestProcesspath that starts the embedded app-server at initialize timeScope
This intentionally keeps tests on child
AppServerTestProcesswhen they exercise process/startup/network/lifecycle behavior, depend on process-global originator isolation, or assertrpc_transport == "stdio".Current constructor count in
codex-rs/app-server/tests:126in-process,219child-process.Validation
just fmtgit diff --checkbazel test --bes_backend= --bes_results_url= --remote_cache= --experimental_remote_downloader= --remote_executor= --nocache_test_results --test_output=errors //codex-rs/app-server:app-server-all-testThe focused devbox run exercised the target after fixing a branch-caused in-process fuzzy-file-search request ordering failure. The remaining failure was in unchanged child-process account refresh tests (
external_auth_refresh_error_fails_turn/external_auth_refresh_invalid_access_token_fails_turn), so this draft leaves that as residual unrelated flake/timing noise rather than widening the branch.