Skip to content

test(app-server): run plain tests in process#22203

Draft
starr-openai wants to merge 1 commit into
mainfrom
starr/app-server-in-process-tests-20260511
Draft

test(app-server): run plain tests in process#22203
starr-openai wants to merge 1 commit into
mainfrom
starr/app-server-in-process-tests-20260511

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

@starr-openai starr-openai commented May 11, 2026

Summary

  • add a lazy in-process AppServerTestProcess path that starts the embedded app-server at initialize time
  • preserve request submission order for embedded JSON-RPC requests
  • move wrapper-gap app-server tests from child stdio processes to the embedded runtime

Scope

This intentionally keeps tests on child AppServerTestProcess when they exercise process/startup/network/lifecycle behavior, depend on process-global originator isolation, or assert rpc_transport == "stdio".

Current constructor count in codex-rs/app-server/tests: 126 in-process, 219 child-process.

Validation

  • just fmt
  • git diff --check
  • devbox focused target:
    bazel test --bes_backend= --bes_results_url= --remote_cache= --experimental_remote_downloader= --remote_executor= --nocache_test_results --test_output=errors //codex-rs/app-server:app-server-all-test

The focused devbox run exercised the target after fixing a branch-caused in-process fuzzy-file-search request ordering failure. The remaining failure was in unchanged child-process account refresh tests (external_auth_refresh_error_fails_turn / external_auth_refresh_invalid_access_token_fails_turn), so this draft leaves that as residual unrelated flake/timing noise rather than widening the branch.

@starr-openai starr-openai force-pushed the starr/app-server-in-process-tests-20260511 branch from 9a06773 to d6773fc Compare May 11, 2026 21:27
@starr-openai starr-openai changed the title test(app-server): move wrapper-gap tests in process test(app-server): run plain tests in process May 11, 2026
@starr-openai starr-openai force-pushed the starr/app-server-in-process-tests-20260511 branch 2 times, most recently from 4b79f87 to 3e68124 Compare May 11, 2026 21:43
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/app-server-in-process-tests-20260511 branch from 3e68124 to 509e267 Compare May 12, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant