[shell command] Reject shell globs in known safe Bash commands#22189
Draft
evawong-oai wants to merge 1 commit into
Draft
[shell command] Reject shell globs in known safe Bash commands#22189evawong-oai wants to merge 1 commit into
evawong-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The known safe classifier was treating unquoted Bash words as stable argv. Bash can rewrite those words at runtime through glob, bracket, brace, or home directory expansion, so a command that looked read only during classification could become an output writing command when the shell executed it.
This PR keeps the fix inside the shell command parser and the safelist regression. It does not broaden unrelated command policy.
Validation
Ticket
CLI 8726