fix(exec-server): suppress Windows taskkill output#22058
Open
fcoury-oai wants to merge 1 commit intomainfrom
Open
fix(exec-server): suppress Windows taskkill output#22058fcoury-oai wants to merge 1 commit intomainfrom
fcoury-oai wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the
exec-serverfollow-up to #21759.#21759 fixed the Windows
taskkilloutput leak for thermcp-clientMCP teardown path, but #22050 showed thatexec-serverstill had a paralleltaskkill /T /Fcleanup path inexec-server/src/connection.rs. Because that command inherited the parent stdio handles, Windows could still printSUCCESS:lines into the user's terminal during stdio child cleanup.This change silences that remaining
exec-servercallsite by redirectingtaskkillstdin, stdout, and stderr toStdio::null().What Changed
Stdioimport inexec-server/src/connection.rstaskkillcommand inkill_windows_process_treetoStdio::null()for stdin, stdout, and stderr.status()and preserving the existing fallback/logging behaviorHow to Test
Manual validation is Windows-only, so I did not run the UI repro path locally here.
exec-serverstdio flow that spawns a child process tree and then triggers transport cleanup.SUCCESS: The process with PID ... has been terminated.lines during cleanup.Targeted tests:
cargo test -p codex-exec-server client::tests::dropping_stdio_client_terminates_spawned_process -- --exactcargo test -p codex-exec-server client::tests::malformed_stdio_message_terminates_spawned_process -- --exactNotes:
cargo test -p codex-exec-serverstill hits unrelated local macOSsandbox-exec: sandbox_apply: Operation not permittedfailures intests/file_system.rs.References