Put Default-mode request_user_input back in /experimental#13798
Closed
charley-oai wants to merge 4 commits intomainfrom
Closed
Put Default-mode request_user_input back in /experimental#13798charley-oai wants to merge 4 commits intomainfrom
charley-oai wants to merge 4 commits intomainfrom
Conversation
Promote DefaultModeRequestUserInput to stable and enable it by default. Update codex-core tool-spec tests to reflect the new default-on behavior while keeping coverage for explicitly disabling the feature. Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review this |
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Update the core request_user_input integration suite to treat Default mode as enabled by default and keep explicit opt-out coverage for the feature flag. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultModeRequestUserInputback toStage::Experimental/experimentalmenu metadata so users can opt in explicitlydefault_mode_request_user_inputand the normalfeatures.default_mode_request_user_inputoverride pathStatsig compatibility
codex-rsfeatures.<key>config entries onthread/startcodex-appscan wire a Statsig gate or layer todefault_mode_request_user_inputthrough the existingstatsig_default_enable_features/ feature-overrides plumbingTesting
just fmtcargo test -p codex-coretest_stdio_serverhelper binary breaks severalrmcp_client/ plugin / truncation testssearch_tool::*tests also failed locallycargo test -p codex-core features::tests::default_mode_request_user_input_is_experimental_and_user_toggleable -- --exactcargo test -p codex-core tools::spec::tests::request_user_input_description_reflects_default_mode_feature_flag -- --exactcargo test -p codex-app-server experimental_feature_list -- --nocapture