Skip to content

Put Default-mode request_user_input back in /experimental#13798

Closed
charley-oai wants to merge 4 commits intomainfrom
default-mode-request-user-input-default-on
Closed

Put Default-mode request_user_input back in /experimental#13798
charley-oai wants to merge 4 commits intomainfrom
default-mode-request-user-input-default-on

Conversation

@charley-oai
Copy link
Collaborator

@charley-oai charley-oai commented Mar 6, 2026

Summary

  • move DefaultModeRequestUserInput back to Stage::Experimental
  • keep it default-off and add /experimental menu metadata so users can opt in explicitly
  • preserve the canonical feature key default_mode_request_user_input and the normal features.default_mode_request_user_input override path
  • update core tests to restore default-off behavior while keeping explicit opt-in coverage for Default mode

Statsig compatibility

  • this PR does not add Statsig gate wiring in codex-rs
  • it keeps the feature compatible with the existing app/desktop Statsig override flow because overrides already materialize as features.<key> config entries on thread/start
  • when ready, codex-apps can wire a Statsig gate or layer to default_mode_request_user_input through the existing statsig_default_enable_features / feature-overrides plumbing

Testing

  • just fmt
  • cargo test -p codex-core
    • locally red in this environment for unrelated existing issues:
      • missing test_stdio_server helper binary breaks several rmcp_client / plugin / truncation tests
      • unrelated search_tool::* tests also failed locally
  • cargo test -p codex-core features::tests::default_mode_request_user_input_is_experimental_and_user_toggleable -- --exact
  • cargo test -p codex-core tools::spec::tests::request_user_input_description_reflects_default_mode_feature_flag -- --exact
  • cargo test -p codex-app-server experimental_feature_list -- --nocapture

Promote DefaultModeRequestUserInput to stable and enable it by default. Update codex-core tool-spec tests to reflect the new default-on behavior while keeping coverage for explicitly disabling the feature.

Co-authored-by: Codex <noreply@openai.com>
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai and others added 2 commits March 6, 2026 14:30
Update the core request_user_input integration suite to treat Default mode as enabled by default and keep explicit opt-out coverage for the feature flag.

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai changed the title Enable Default-mode request_user_input by default Put Default-mode request_user_input back in /experimental Mar 7, 2026
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant