Skip to content

feat: support disabling bundled system skills#13792

Open
xl-openai wants to merge 1 commit intomainfrom
xl/skills
Open

feat: support disabling bundled system skills#13792
xl-openai wants to merge 1 commit intomainfrom
xl/skills

Conversation

@xl-openai
Copy link
Collaborator

Support disable bundled system skills when starting app-server.

@xl-openai xl-openai requested a review from pakrym-oai March 6, 2026 20:31
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 833fb540a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +47 to +50
if disable_system_skills {
// The loader always checks `skills/.system`, so disabling bundled skills must clear
// any stale cached copy. This is best-effort; startup should not fail if removal does.
uninstall_system_skills(&manager.codex_home);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Persistently exclude .system skills when disable flag is set

SkillsManager::new only removes skills/.system once at startup. Later skill loads still call skill_roots(...), which always includes the .system root. If another Codex process repopulates .system after startup, app-server will reload and expose bundled system skills again even with --disable-bundled-system-skills.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant