Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 833fb540a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if disable_system_skills { | ||
| // The loader always checks `skills/.system`, so disabling bundled skills must clear | ||
| // any stale cached copy. This is best-effort; startup should not fail if removal does. | ||
| uninstall_system_skills(&manager.codex_home); |
There was a problem hiding this comment.
Persistently exclude .system skills when disable flag is set
SkillsManager::new only removes skills/.system once at startup. Later skill loads still call skill_roots(...), which always includes the .system root. If another Codex process repopulates .system after startup, app-server will reload and expose bundled system skills again even with --disable-bundled-system-skills.
Useful? React with 👍 / 👎.
Support disable bundled system skills when starting app-server.