Skip to content

test: preserve Windows CI timeouts in isolated tests - #608

Open
faizan-oai wants to merge 1 commit into
mainfrom
agent/fix-windows-ci-test-timeouts
Open

test: preserve Windows CI timeouts in isolated tests#608
faizan-oai wants to merge 1 commit into
mainfrom
agent/fix-windows-ci-test-timeouts

Conversation

@faizan-oai

@faizan-oai faizan-oai commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the Windows CI timeout mismatch exposed by the failing main-branch run. Windows shards allow 120 seconds per test, but isolated child tests still used a hard-coded 30-second deadline.

Changes

  • Pass the existing Windows shard timeout to isolated Bun tests through a test-only environment value.
  • Keep the existing 30-second fallback outside the Windows shard runner.
  • Add a behavioral regression that verifies the configured timeout is enforced by the isolated child test.

Testing

  • Verified the new regression fails with the previous hard-coded timeout and passes with the fix.
  • bun test --timeout 30000 --seed 12345 tests-ts/skeleton.test.ts — 9 passed.
  • pnpm run types — passed.
  • pnpm run format — passed.
  • node scripts/run-windows-ci-tests.mjs on Windows, with machine-wide policy tests disabled — 1,517 passed, 58 skipped, and two native permission/plugin-cache failures. Both failed cases passed when rerun separately. The affected api.test.ts shard passed all 117 tests.
  • GitHub node-ci — all 24 jobs passed across Linux, macOS, and Windows. The original failing cleanup test passed on both Windows Node versions.
  • Container CI and container release validation — passed.

Risk and rollout

Test infrastructure only; no shipped CLI, SDK, credential-handling, or public API changes. The Windows 120-second test budget and ten-minute shard limit are unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-08-21T22:43:47.595994Z b1759c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant