test: preserve Windows CI timeouts in isolated tests - #608
Open
faizan-oai wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows CI timeout mismatch exposed by the failing main-branch run. Windows shards allow 120 seconds per test, but isolated child tests still used a hard-coded 30-second deadline.
Changes
Testing
bun test --timeout 30000 --seed 12345 tests-ts/skeleton.test.ts— 9 passed.pnpm run types— passed.pnpm run format— passed.node scripts/run-windows-ci-tests.mjson Windows, with machine-wide policy tests disabled — 1,517 passed, 58 skipped, and two native permission/plugin-cache failures. Both failed cases passed when rerun separately. The affectedapi.test.tsshard passed all 117 tests.Risk and rollout
Test infrastructure only; no shipped CLI, SDK, credential-handling, or public API changes. The Windows 120-second test budget and ten-minute shard limit are unchanged.
Public disclosure review