fix: Save scan instructions before Deep workers start - #600
Open
ianw-oai wants to merge 1 commit into
Open
Conversation
ianw-oai
marked this pull request as ready for review
August 21, 2026 16:38
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SDK sent scan instructions to the parent agent but did not save them with the scan. Deep workers read the saved scan context, so they could start without these instructions.
Save
options.scanPromptinscans.user_contextduring registration, before workers start. This does not depend on the parent agent to copy the text.Changes
Testing
All checks passed on the final patch:
pnpm run test --seed 12345 --only-failures: 1,484 passed, 29 skipped, 0 failed.pnpm run test --only-failures(seed666922896): 1,484 passed, 29 skipped, 0 failed.pnpm run typespnpm run formatgit diff --checkRisk and rollout
No public commands, flags, settings, or prompt text change. Scans without a scan prompt keep the existing behavior. Knowledge-base handling is unchanged.
The change uses the existing context field and transaction. No database migration or special rollout step is required. It applies to new scan registrations and does not change saved scans.
Public disclosure review