Fix codex-home input for safety-strategy: unprivileged-user#100
Open
WKBae wants to merge 1 commit intoopenai:mainfrom
Open
Fix codex-home input for safety-strategy: unprivileged-user#100WKBae wants to merge 1 commit intoopenai:mainfrom
codex-home input for safety-strategy: unprivileged-user#100WKBae wants to merge 1 commit intoopenai:mainfrom
Conversation
`sudo` resets the environment by default. When the `codex-home` input is set, `runCodexExec` adds `CODEX_HOME` to the environment passed to `spawn()`. For `unprivileged-user`, however, the spawned process is `sudo`, which then runs `codex exec` as the target user. Without preserving the environment, `CODEX_HOME` is not propagated to the Codex process, so the CLI may read configuration from the target user's default Codex home instead. This change passes `-E` (`--preserve-env`) to `sudo` so the unprivileged Codex process receives the environment prepared by the action.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudoresets the environment by default.When the
codex-homeinput is set,runCodexExecaddsCODEX_HOMEto the environment passed tospawn(). Forunprivileged-user, however, the spawned process issudo, which then runscodex execas the target user. Without preserving the environment,CODEX_HOMEis not propagated to the Codex process, so the CLI may read configuration from the target user's default Codex home instead.This change passes
-E(--preserve-env) tosudoso the unprivileged Codex process receives the environment prepared by the action.Fixes #99