Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates legacy SmartHome web theme assets and MQTT publishing helper to restore compatibility with classic themes and legacy SmartHome message formats.
Changes:
- Switch classic theme SmartHome page to load the MQTT library version used elsewhere in the legacy theme.
- Extend
Pub().pub()to support ano_jsonflag and wire it throughpub_single()so legacy SmartHome can publish raw payloads when needed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/modules/web_themes/standard_legacy/web/smartHome.html | Updates MQTT library script reference for the legacy SmartHome page. |
| packages/helpermodules/pub.py | Adds no_json support to Pub().pub() and forwards it through pub_single(); simplifies remote publish serialization logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no_jsoninPub().pub(), used by legacy SmartHome