Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Elgris device integration by aligning Modbus connection handling with the device-level updater and ensuring the Elgris SDM subclass has required runtime state, plus adds basic unit coverage for the Elgris components.
Changes:
- Remove per-component
with tcp_client:blocks so Modbus context is managed once in the device updater. - Initialize
fast_modeon theElgrisSDM-derived class to supportget_counter_state()execution. - Add an
elgris_test.pycovering bat/counter/inverter updates via mocked Modbus reads.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/devices/elgris/elgris/inverter.py | Removes nested Modbus context management in inverter update. |
| packages/modules/devices/elgris/elgris/counter.py | Removes nested Modbus context management in counter update. |
| packages/modules/devices/elgris/elgris/bat.py | Removes nested Modbus context management in battery update. |
| packages/modules/devices/elgris/elgris/elgris.py | Sets fast_mode to avoid runtime attribute errors in SDM logic. |
| packages/modules/devices/elgris/elgris/elgris_test.py | Adds tests using monkeypatched Modbus methods to validate state writes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+27
to
+28
| device = create_device(Elgris()) | ||
| device.add_component(ElgrisBatSetup()) |
Comment on lines
+48
to
+49
| device = create_device(Elgris()) | ||
| device.add_component(ElgrisCounterSetup(id=1)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.