Skip to content

Feat/improve filter#934

Merged
zven merged 71 commits into
devfrom
feat/improve-filter
May 18, 2026
Merged

Feat/improve filter#934
zven merged 71 commits into
devfrom
feat/improve-filter

Conversation

@jona159
Copy link
Copy Markdown
Contributor

@jona159 jona159 commented May 7, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

jona159 and others added 30 commits May 4, 2026 09:31
@jona159
feat: info menu
ee994a1
@jona159
feat: add topbar button variant for coherent styling
64aa69f
@jona159
feat: use osem logo with text for home button
b8e8768
@jona159
feat: info menu component with informational links
5f3b642
@jona159
feat: translations
80293a1
@jona159
feat: add method to get total count of measurements
bd076c7
@jona159
feat: download label
547d029
@jona159
feat: topbar component, show devices and measurement stats
2d5e4eb
@jona159
feat: format
0018345
@jona159
refactor: download component
bbd2552
@jona159
feat: adjust info component
6fa1d32
@jona159
feat: adjust menu component
c391a21
@jona159
feat: add settings component for header, minor things
3aaa261
@jona159
Merge branch 'dev' into feat/reorganize-toplevel-navigation
4b8d4af
@jona159
fix: after conflict
589665f
@jona159
fix: pass user from loader
db30406
@jona159
fix: rm unnecessary stuff
7ad4908
@jona159
feat: show logo and stats together
e165f30
@jona159
feat: add language dialog for the future
98d6fee
@jona159
feat: show current language on hover only
3f2063f
@jona159
fix: dont show settings menu for now
f58a169
@jona159
fix: rm translation
528a2b9
@jona159
fix: rm useless mailbox icon, readd menu
913cd75
@jona159
fix: show donwload option also when not logged in
9ed3f4e
@jona159
feat: zoom to initial view state on home click
22fb5aa
@jona159
fix: rm unnecessary div
ae889bf
@jona159
fix: download
dc04511
@scheidtdav
Merge branch 'dev' into feat/reorganize-toplevel-navigation
f8b9535
@jona159 @scheidtdav
feat: make map landing page, mv current to about (#907)
b8e51a4 
* feat: make map landing page, mv current to about

* fix: update copyright year

* feat: improve hosted text

* fix: copyright year, twitter icon

* fix: translations

* fix: openSenseLab logo

* fix: rm scroll snapping

* fix: translations

* feat: animate heading

* fix: rm features

* feat: show copyright year dynamically

---------

Co-authored-by: David Scheidt <scheidtdav@users.noreply.github.com>
@dependabot @jona159
build(deps): bump @directus/sdk from 21.2.2 to 21.3.0 (#924)
6f197b6 
Bumps [@directus/sdk](https://github.com/directus/directus/tree/HEAD/sdk) from 21.2.2 to 21.3.0.
- [Release notes](https://github.com/directus/directus/releases)
- [Commits](https://github.com/directus/directus/commits/HEAD/sdk)

---
updated-dependencies:
- dependency-name: "@directus/sdk"
  dependency-version: 21.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 7, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​base-ui/​react@​1.4.1901008993100

View full report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.06% 1775 / 2570
🔵 Statements 67.37% 1844 / 2737
🔵 Functions 69.24% 367 / 530
🔵 Branches 56.13% 947 / 1687
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/db/models/device.server.ts 64.12% 67.87% 62.5% 64.7% 86-91, 99, 151-152, 221-236, 276, 339, 368, 395, 399, 407-409, 415-417, 433-435, 439-441, 488-642, 693-697, 725-731, 736-752, 831-833, 844, 851-852, 860, 887, 988-1008, 1027
app/db/schema/sensor.ts 85.71% 100% 75% 83.33% 42
app/routes/api.boxes.$deviceId.ts 67.14% 50.81% 66.66% 68.65% 77, 86-100, 108, 114-121, 130, 139-142, 147-153, 159-185, 209, 249-256, 263, 268-270, 280-281
app/routes/api.boxes.ts 90.47% 100% 100% 90.47% 390-391, 448-449
app/services/device-service.server.ts 59.37% 42.42% 64% 58.62% 104, 115-120, 150-151, 161, 170-173, 184-201, 209, 229-234, 252, 269-272, 291-294
app/services/measurement-service.server.ts 67.21% 66.29% 100% 69.23% 32, 51, 88, 91, 108, 129, 131, 135, 140, 147-149, 161-163, 179-181, 187-189, 196-198, 214-216, 296-303, 311-320
Generated in workflow #2554 for commit 59828fc by the Vitest Coverage Report Action

@jona159 jona159 linked an issue May 7, 2026 that may be closed by this pull request
update filter feature on map #918
Closed
zven
zven reviewed May 11, 2026
View reviewed changes
Comment thread app/components/header/nav-bar/filter-panel.tsx Outdated
zven
zven reviewed May 12, 2026
View reviewed changes
Comment thread app/db/models/device.server.ts Outdated
zven
zven reviewed May 12, 2026
View reviewed changes
Comment thread app/db/models/phenomena.server.ts Outdated
zven
zven reviewed May 12, 2026
View reviewed changes
Comment thread app/db/models/phenomena.server.ts Outdated
zven
zven reviewed May 12, 2026
View reviewed changes
Comment thread app/routes/explore.tsx
zven
zven reviewed May 12, 2026
View reviewed changes
Comment thread app/routes/explore.tsx Outdated
@zven
Copy link
Copy Markdown
Member

zven commented May 12, 2026

One general comment: You are making ample use of inline css styling for the filter UI. Do you think it would be feasible to at least turn some of those into re-usable elemets?

@zven zven merged commit 258df59 into dev May 18, 2026
6 checks passed
@zven zven deleted the feat/improve-filter branch May 18, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zven zven zven approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update filter feature on map

3 participants

@jona159 @zven @scheidtdav