Custom hierarchies – other API concept, for now without extended meshes and particles path #1881
Open
franzpoeschel wants to merge 58 commits into
Open
Custom hierarchies – other API concept, for now without extended meshes and particles path #1881franzpoeschel wants to merge 58 commits into
franzpoeschel wants to merge 58 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } // namespace | ||
|
|
||
| std::future<void> AbstractIOHandlerImpl::flush(FlushLevel l) |
| // method might be called as const. shared_ptr<>s implement interior | ||
| // mutability, so use that here. | ||
|
|
||
| // auto &container_front = container.container_front(); |
| { | ||
| setDirty(false); | ||
| } | ||
| // customHierarchies().printRecursively(); |
| std::to_string(count_of_erased_elements) + " instead."); | ||
| } | ||
|
|
||
| // std::cout << "REWIRED '" << myPath().openPMDPath() << "'." << std::endl; |
| if (res.first->first == RecordComponent::SCALAR) | ||
| { | ||
| this->container().erase(res.first); | ||
| // this->container().erase(res.first); |
| read_nonexistent_attribute::read_nonexistent_attribute(); | ||
| } | ||
|
|
||
| TEST_CASE("custom_hierarchy", "[core]") |
franzpoeschel
force-pushed
the
custom-hierarchies
branch
3 times, most recently
from
036bd34 to
96307f3
Compare
This makes it easier to keep MPI processes in sync
These were unnecessary, but they snuck WRITE_ATT tasks into the skeleton flush.
not so great, but lets keep that for now
This reverts commit 6a5c9f5.
This reverts commit 246609ff5fbe5edb68119b7f3b29a40e7bf23d2d.
This reverts commit 2df195749b53b0a54832585899bd469d35f81d6d.
This reverts commit 07fb558.
Most of the .cpp file currently commented out
now custom flushing and reading yet
franzpoeschel
force-pushed
the
custom-hierarchies
branch
from
233aab3 to
6bd551d
Compare
| #endif | ||
| } | ||
|
|
||
| TEST_CASE("append_mode", "[serial]") |
| #endif | ||
| } | ||
|
|
||
| TEST_CASE("append_mode", "[serial]") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tbd
TODO:
Diff: franzpoeschel/openPMD-api@fix-parallel-hdf5...custom-hierarchies