Replace error with warning for unmapped instance folders#82
Merged
ehennestad merged 11 commits intomainfrom Mar 26, 2026
Merged
Replace error with warning for unmapped instance folders#82ehennestad merged 11 commits intomainfrom
ehennestad merged 11 commits intomainfrom
Conversation
Remove concatenation of structs. Structs might have different fields, and the concatenation would fail. Only need name and potentially label, so explicitly get these instead of relying on struct concatenation
Replace a hard error for unimplemented instance folder names with a warning that is emitted only once per unique folder name. Introduces a containers.Map (hasWarned) to track which folder names have already triggered the warning and uses the identifier 'OPENMINDS:InstanceLibrary:createInstanceTable:MissingTypeMapping'. This avoids aborting execution for unmapped folders while preventing repeated duplicate warnings.
Contributor
Test Results (R2021b)568 tests ±0 568 ✅ ±0 1m 29s ⏱️ -1s Results for commit 62b5c51. ± Comparison against base commit 048b729. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Test Results (R2024b)568 tests ±0 568 ✅ ±0 1m 29s ⏱️ -1s Results for commit 62b5c51. ± Comparison against base commit 048b729. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Replace UBERONParcellation with BiologicalSex. UBERONParcellation has been removed in latest
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 75.73% 75.78% +0.04%
==========================================
Files 349 349
Lines 3734 3741 +7
==========================================
+ Hits 2828 2835 +7
Misses 906 906 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #81
Replace a hard error for unimplemented instance folder names with a warning that is emitted only once per unique folder name. Introduces a containers.Map (hasWarned) to track which folder names have already triggered the warning and uses the identifier 'OPENMINDS:InstanceLibrary:createInstanceTable:MissingTypeMapping'. This avoids aborting execution for unmapped folders while preventing repeated duplicate warnings.