Open
Conversation
Member
|
I don't see any obvious errors, although it is difficult to review because if I expand the context my browser hangs due to the size of the file, so let's merge this and fix any problems as we encounter them. |
apdavison
approved these changes
Mar 26, 2026
| @@ -26190,7 +26189,7 @@ | |||
| "https://openminds.ebrains.eu/sands/AnatomicalEntity" | |||
| ] | |||
| }, | |||
| "nameForReverseLink": null | |||
| "nameForReverseLink": "wasSemanticallyAnchoredIn" | |||
Member
There was a problem hiding this comment.
This property is deprecated, but it feels odd to see 'was' instead of 'is', especially compared to other inverse properties.
Member
|
General comment: I’m not sure we need reverse links to QuantitativeValue or QuantitativeValueArray instances, since identical measurements would typically be reused rather than linked separately. That also feels a bit inconsistent with our perception of embedded types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@apdavison I did not use the fairgraph suggestions, because I don't think that they are all correct (and avoiding ambiguous reverse linkages).
@apdavison @Raphael-Gazzotti @olinux I semi-automatically generated the ones in this PR now for each property (without over harmonizing which I'm not really sure is working several cases).
For now I would suggest to merge this (if there is no obvious error) and then we can revisit the whole concept and discuss about conventions (also for property names in general) in the future.