WEB-1105: Fix collateral edit Cancel button redirecting to blank screen - #3797
WEB-1105: Fix collateral edit Cancel button redirecting to blank screen#3797Farah-Nahle-FOO wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Note
|
| Layer / File(s) | Summary |
|---|---|
Update cancel route src/app/collaterals/edit-collateral/edit-collateral.component.html |
The cancel button's routerLink changes from ['../../'] to ['../']. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly identifies the collateral edit Cancel button redirect fix and matches the main change. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The Cancel button on the client collateral edit form linked to '../../', overshooting the collateral view route (only one level up) and landing on a path with no matching component.
c2b5838 to
670419d
Compare
|
@Farah-Nahle-FOO please rebase |
2 participants
Description
The Cancel button on the client collateral edit form linked to
../../, overshooting the collateral view route (only one level up) and landing on a path with no matching component. This produced a blank screen instead of returning the user to the collateral's details page.Changed the Cancel button's
routerLinkfrom['../../']to['../']so it matches the same relative navigation already used by the Submit handler, correctly returning the user to the collateral view page without making any changes.No new dependencies are required for this change.
Related issues and discussion
WEB-1105
Screenshots, if any
Before: Clicking Cancel on the collateral edit form results in a blank screen.
After: Clicking Cancel returns the user to the collateral's details/view page.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit