WEB-1098: Fix Home search missing modules and blank 404 entry - #3791
WEB-1098: Fix Home search missing modules and blank 404 entry#3791Farah-Nahle-FOO wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Note
|
| Layer / File(s) | Summary |
|---|---|
Activity entries src/app/home/activities.ts |
The activity list adds six navigable records and removes the empty home record. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly summarizes the main changes: adding missing Home search modules and removing the blank 404 entry. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/home/activities.ts`:
- Line 67: Update the activity definitions around “checker inbox and tasks” so
the existing filters in home and dashboard can match “tasks” as an independent
search term; preferably replace the combined record with separate “checker
inbox” and “tasks” records while preserving the appropriate route behavior.
- Around line 62-67: Replace the literal activity labels in the activity
definitions with translation keys, add translations for loans, collections,
notifications, profile, settings, and checker inbox and tasks, and resolve those
keys before the Home and Dashboard components render, search, or filter
activities. Run npm run translations:extract after adding the i18n keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5f64f5b5-e265-4040-b5f4-5015083be431
📒 Files selected for processing (1)
src/app/home/activities.ts
| { activity: 'notifications', path: '/notifications' }, | ||
| { activity: 'profile', path: '/profile' }, | ||
| { activity: 'settings', path: '/settings' }, | ||
| { activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make “tasks” searchable as its own activity.
src/app/home/home.component.ts (Lines 66-133) and src/app/home/dashboard/dashboard.component.ts (Lines 40-84) only match activity names from the beginning. The label checker inbox and tasks does not match a search for tasks. Add separate checker inbox and tasks records, or update the shared filter to support token matching.
Based on the downstream filtering in src/app/home/home.component.ts (Lines 66-133) and src/app/home/dashboard/dashboard.component.ts (Lines 40-84), the activity label must match the search term.
Possible local fix
- { activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' }
+ { activity: 'checker inbox', path: '/checker-inbox-and-tasks' },
+ { activity: 'tasks', path: '/checker-inbox-and-tasks' }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' } | |
| { activity: 'checker inbox', path: '/checker-inbox-and-tasks' }, | |
| { activity: 'tasks', path: '/checker-inbox-and-tasks' } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/app/home/activities.ts` at line 67, Update the activity definitions
around “checker inbox and tasks” so the existing filters in home and dashboard
can match “tasks” as an independent search term; preferably replace the combined
record with separate “checker inbox” and “tasks” records while preserving the
appropriate route behavior.
699f4f6 to
a61e8fc
Compare
|
@Farah-Nahle-FOO please review the comments |
2 participants
Description
The Home screen's "Search Activity" box was missing several modules from its results (Loans, Collections, Notifications, Profile, Settings, Checker Inbox & Tasks were never indexed), and the last entry in the dropdown had a blank label and pointed to an unqualified relative path (
home), which resolved to/home/homeand hit the 404 page when clicked.This change removes the blank/broken entry and adds the missing modules to the search index so global search covers every module in the portal.
Related issues and discussion
WEB-1098
Screenshots, if any
Before: blank row in the search dropdown, clicking it → 404 page.
After: no blank row; searching "loans", "collections", "notifications", "profile", "settings", or "checker inbox" now returns a matching result.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
New Features
Bug Fixes