Skip to content

Tag Docker image with git tag on main releases - #3700

Open
StefanB7 wants to merge 1 commit into
openMF:devfrom
StefanB7:docker-tag-on-git-tag
Open

Tag Docker image with git tag on main releases#3700
StefanB7 wants to merge 1 commit into
openMF:devfrom
StefanB7:docker-tag-on-git-tag

Conversation

@StefanB7

@StefanB7 StefanB7 commented Jul 2, 2026

Copy link
Copy Markdown

Description

Adds tagging of docker images with the same git tags present on that commit.

I've been trying to run the mifos web app, but it was not easy to pull the latest release from docker hub. Having a docker image tagged with v1.0.0-fineract1.14 would have been super useful. This PR adds that.

Related issues and discussion

I read web-app/.github/CONTRIBUTING.md. It instructs new contributors to ask if they should implement a new feature on slack first. I am having trouble joining the slack, it seems like I need an email under a set of subdomains:

image

which I don't have.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/create-docker-hub-image.yml is excluded by !.github/** and included by **/*

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d3809872-513a-42dc-ae8b-f9756946f3da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "pre_merge_checks"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IOhacker

IOhacker commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@StefanB7 assign this ticket to yourself in Jira https://mifosforge.jira.com/browse/WEB-1023 add this title in the PR "WEB-1023: Add tags for docker Hub"

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review my comments

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions Bot added the Stale label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants