Web 963 add alt text for account profile images#3608
Conversation
|
Warning Review limit reached
Your plan currently allows 2 reviews/hour. Refill in 5 minutes and 15 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Note
|
| Layer / File(s) | Summary |
|---|---|
Profile image alt attributes src/app/clients/clients-view/clients-view.component.html, src/app/deposits/fixed-deposits/fixed-deposit-account-view/fixed-deposit-account-view.component.html, src/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.html, src/app/savings/savings-account-view/savings-account-view.component.html, src/app/shares/shares-account-view/shares-account-view.component.html |
Each template's profile image element now includes an alt attribute: client binds to clientViewData.displayName; account views bind to the appropriate translated tooltips.* string. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
- gkbishnoi07
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title directly and accurately summarizes the main change: adding alt text for account profile images across multiple views for accessibility. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
RiteshGite
force-pushed
the
WEB-963-add-alt-text-for-account-profile-images
branch
from
af32d53 to
d3b732b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/clients/clients-view/clients-view.component.html`:
- Line 18: The alt binding currently uses clientViewData.displayName which can
be missing; update the profile image alt binding in clients-view.component.html
so it falls back to the translated label when clientViewData.displayName is
falsy by using a logical-or fallback with the translate pipe (use
('labels.inputs.Display Name' | translate)) so the alt always has a meaningful
value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b2565c60-e95e-43a0-9b84-0214ee19fe69
📒 Files selected for processing (5)
src/app/clients/clients-view/clients-view.component.htmlsrc/app/deposits/fixed-deposits/fixed-deposit-account-view/fixed-deposit-account-view.component.htmlsrc/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.htmlsrc/app/savings/savings-account-view/savings-account-view.component.htmlsrc/app/shares/shares-account-view/shares-account-view.component.html
✅ Files skipped from review due to trivial changes (2)
- src/app/shares/shares-account-view/shares-account-view.component.html
- src/app/deposits/fixed-deposits/fixed-deposit-account-view/fixed-deposit-account-view.component.html
RiteshGite
force-pushed
the
WEB-963-add-alt-text-for-account-profile-images
branch
from
d3b732b to
810f215
Compare
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
Can you add screenshot or video? seems that there are unrelated changes
2 participants
Description
Added missing
alttext for account profile images across multiple account view pages to improve accessibility support for screen readers and assistive technologies.Previously, several views used profile images without meaningful alternative text, which caused accessibility issues under WCAG 1.1.1 guidelines.
This update adds appropriate
altattributes by reusing existing translated tooltip values where applicable, while the client view uses the client display name for more descriptive image context.Affected views:
No UI or behavioral changes were introduced.
Related issues and discussion
#WEB-963
Screenshots, if any
N/A (accessibility text-only change)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit