WEB-961: fix incorrect account action aria-labels#3603
Conversation
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Correct aria-labels in account view templates src/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.html, src/app/savings/savings-account-view/savings-account-view.component.html |
Replaced static aria-label="Loan account actions" with translated [attr.aria-label] bindings: recurring deposits and savings account action buttons now use their respective translated labels. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately and specifically describes the main change: fixing incorrect aria-labels in account action menus across multiple components. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Warning
Review ran into problems
🔥 Problems
Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.html`:
- Line 89: Replace the hardcoded aria-label="Recurring deposit account actions"
with a translatable value using the ngx-translate pipe (e.g. use the aria-label
binding with "'recurringDeposits.account.actions' | translate" or
[attr.aria-label]="'recurringDeposits.account.actions' | translate") so screen
readers get the localized string; update the i18n key name to match your
conventions (suggested key: recurringDeposits.account.actions) and then run npm
run translations:extract to add the new key to your translation files.
In `@src/app/savings/savings-account-view/savings-account-view.component.html`:
- Line 108: Replace the hardcoded aria-label on the actions control in the
SavingsAccountViewComponent template by using the `@ngx-translate/core` translate
pipe (e.g. aria-label="{{ 'savings.accountActions' | translate }}" or
[attr.aria-label]="'savings.accountActions' | translate") instead of the English
string; add the new i18n key (e.g. savings.accountActions = "Savings account
actions") to your translation files and then run npm run translations:extract to
pick up the new key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5d7700a8-85a4-43e2-8819-6a34edbddfdd
📒 Files selected for processing (2)
src/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.htmlsrc/app/savings/savings-account-view/savings-account-view.component.html
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
Review the CodeRabbit suggestions
alberto-art3ch
left a comment
alberto-art3ch
left a comment
There was a problem hiding this comment.
In general looks OK, but Please only one commit for PR
RiteshGite
force-pushed
the
WEB-961-fix-account-action-aria-labels
branch
from
e8183bb to
2c5e2ec
Compare
|
Addressed the CodeRabbit suggestions by using translated aria-label bindings with existing i18n keys and squashed the PR into a single commit. |
3 participants
Description
Fixed incorrect
aria-labelvalues used in the account action menus for Savings Account View and Recurring Deposit Account View.Previously, both views incorrectly used the label
"Loan account actions"due to a copy-paste issue. This caused incorrect context for screen readers and accessibility tools.The labels have been updated to reflect the correct account types:
"Savings account actions""Recurring deposit account actions"This is a small accessibility improvement with no UI or behavioral changes.
Related issues and discussion
#WEB-961
Screenshots, if any
N/A (accessibility text-only change)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit