WEB-954: Performance, Subscription management migration#3590
Open
alberto-art3ch wants to merge 1 commit into
Open
WEB-954: Performance, Subscription management migration#3590alberto-art3ch wants to merge 1 commit into
alberto-art3ch wants to merge 1 commit into
Conversation
|
Important Review skippedToo many files! This PR contains 182 files, which is 32 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (182)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
alberto-art3ch
force-pushed
the
WEB-954/migrate-subscription-management
branch
from
e48ea25 to
b0043f5
Compare
IOhacker
requested changes
May 19, 2026
Contributor
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
This seems AI generated, too many file changes in a PR to be properly tested
alberto-art3ch
force-pushed
the
WEB-954/migrate-subscription-management
branch
3 times, most recently
from
066ea2c to
9d054f8
Compare
alberto-art3ch
force-pushed
the
WEB-954/migrate-subscription-management
branch
from
9d054f8 to
1289e44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate subscription management from Subject / takeUntil to DestroyRef / takeUntilDestroyed across the application
Refactor to replace the manual subscription cleanup pattern (
Subject<void> + takeUntil(this.destroy$) + ngOnDestroy)with Angular's built-in DestroyRef token and thetakeUntilDestroyed()operator.Related issues and discussion
WEB-954
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.