Skip to content

WEB-888 Add missing validation error messages for required fields in loan reage and foreclosure forms#3430

Open
JaySoni1 wants to merge 1 commit intoopenMF:devfrom
JaySoni1:WEB-888-add-missing-validation-error-messages-for-required-fields-in-loan-re-age-and-foreclosure-forms
Open

WEB-888 Add missing validation error messages for required fields in loan reage and foreclosure forms#3430
JaySoni1 wants to merge 1 commit intoopenMF:devfrom
JaySoni1:WEB-888-add-missing-validation-error-messages-for-required-fields-in-loan-re-age-and-foreclosure-forms

Conversation

@JaySoni1
Copy link
Copy Markdown
Contributor

@JaySoni1 JaySoni1 commented Mar 22, 2026

Changes Made :-

-Add validation error messages for required Frequency Type field in Loan Re-Age and Note field in Foreclosure forms .

WEB-888

Before :-

image image

After :-

image image

Summary by CodeRabbit

  • Bug Fixes
    • Added required field validation to the Note field in the foreclosure form with error messaging displayed when the field is left empty
    • Added required field validation to the Frequency Type selection in the loan reaging form with error messaging displayed when no option is selected

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 22, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: effd5f67-7581-456f-b999-3d250526455f

📥 Commits

Reviewing files that changed from the base of the PR and between 7886c79 and 33a2afc.

📒 Files selected for processing (2)
  • src/app/loans/loans-view/loan-account-actions/foreclosure/foreclosure.component.html
  • src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html

Walkthrough

Two form template files were updated to add required field validation and corresponding error message UI. The foreclosure component's note textarea and the loan-reaging component's frequency type selector now have required validation attributes, with conditional error messages displayed when validation fails.

Changes

Cohort / File(s) Summary
Form Validation UI Enhancements
src/app/loans/loans-view/loan-account-actions/foreclosure/foreclosure.component.html, src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html
Added required attribute to form controls (note textarea and frequency type selector) with conditional mat-error elements that display translated validation error messages when fields fail required validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • gkbishnoi07
  • alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main changes: adding validation error messages for required fields in two loan forms (re-age and foreclosure).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant