WEB-628: Standardized login password minimum length validation#3050
Closed
Ambika-Sony wants to merge 1 commit intoopenMF:devfrom
Closed
WEB-628: Standardized login password minimum length validation#3050Ambika-Sony wants to merge 1 commit intoopenMF:devfrom
Ambika-Sony wants to merge 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Password Validation Update src/app/login/login-form/login-form.component.ts |
Reduced minimum password length requirement from 8 to 4 characters in the password validator |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested reviewers
- IOhacker
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check | The PR title mentions 'Standardized login password minimum length validation' but the actual change lowered the minimum from 12 to 4 characters, not standardized it to a specific value. Additionally, the title says 'WEB-628' while the PR objectives reference 'FINERACT-2451', creating a mismatch. The title is partially related but misleading about what 'standardized' means in this context. | Update the title to accurately reflect the change, such as 'WEB-628: Lower login password minimum length validation from 12 to 4 characters' or 'WEB-628: Reduce minimum password length requirement to 4 characters'. Also verify the correct issue identifier (WEB-628 vs FINERACT-2451) matches across the PR. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/login/login-form/login-form.component.ts (1)
125-130: Align password minimum length with the PR objective (8 chars).The PR objective explicitly targets a minimum length of 8 to match the default credential
"password". Setting 4 here undercuts that requirement and weakens password policy. Please update to 8 so UI validation matches the intended standard.🔧 Proposed fix
password: [ '', [ Validators.required, - Validators.minLength(4) + Validators.minLength(8) ] ],
Author
|
"Fixed. I have updated the minLength to 8 to align with the PR objective
and default system credentials. Thank you for the catch!"
…On Mon, Jan 26, 2026 at 11:51 AM coderabbitai[bot] ***@***.***> wrote:
***@***.***[bot]* commented on this pull request.
*Actionable comments posted: 0*
Caution
Some comments are outside the diff and can’t be posted inline due to
platform limitations.
|
Ambika-Sony
changed the title
Ambika-Sony
force-pushed
the
fix/password-validation-FINERACT-2451
branch
from
f9bd956 to
d605218
Compare
Contributor
|
There is no file changed in the PR |
Contributor
|
hi @Ambika-Sony this PR doesn't have any file |
Collaborator
|
@Ambika-Sony are you still working on it?? we cannot see any file change |
Author
|
Hi @gkbishnoi07, I've decided to focus my efforts entirely on *Fineract
Backend* and *AI/ML* projects for my GSoC 2026 proposal. To keep the
project board clean and allow someone else to take up this task, I am
closing this PR. I look forward to contributing to the community in the
backend space!
Thank you for your guidance
…On Mon, Feb 16, 2026 at 4:52 AM Gopi Kishan ***@***.***> wrote:
*gkbishnoi07* left a comment (openMF/web-app#3050)
<#3050 (comment)>
@Ambika-Sony <https://github.com/Ambika-Sony> are you still working on
it?? we cannot see any file change
—
Reply to this email directly, view it on GitHub
<#3050 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIN7S2EHRHRPPHEF5FCMB5D4MD5SDAVCNFSM6AAAAACS32QRZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBVGQYTQNJXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the inconsistency between the Frontend UI validation and the Backend/Database default credentials, which is now tracked under WEB-628.
Previously, the UI enforced a 12-character minimum password length, which blocked access for the default system credential 'password' (8 characters). I have updated the validator to allow an 8-character minimum to match these default settings and improve the onboarding experience for new developers.
Related issues and discussion
Fixes #WEB-628
(Note: Originally reported as FINERACT-2451; moved to the MifosForge WEB board per mentor guidance).
Screenshots
Before (Bug)
The UI blocked the login button because the password 'password' did not meet the 12-character requirement.
After (Fixed)
The UI now accepts the 8-character default password, allowing successful login to the Mifos dashboard.
Checklist
[x ] If you have multiple commits please combine them into one commit by squashing them.
[x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md