WEB-340 replace custom api of saving.service.ts

[JaySoni1]

Replaced custom methods in *.ts files that were previously using SavingService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[JaySoni1]

@gkbishnoi07 Please Review

[gkbishnoi07]

Okay

[steinwinde]

@gkbishnoi07 , I assume that your comment means that you are still reviewing this? I don't want to appear pushy - just want to make sure I understand your comment.

[gkbishnoi07]

cannot create saving account getting error

[gkbishnoi07]

please test your PR first

[JaySoni1]

@gkbishnoi07 I have update the PR please review .

[gkbishnoi07]

please test it properly

[github-actions]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

[JaySoni1]

@gkbishnoi07 I have a few doubts regarding this PR, so I have messaged you on Slack. Please check

[github-actions]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

[Saifulhuq01]

Hi @JaySoni1 and @gkbishnoi07,

I encountered the same blocker regarding the charges payload (API failure on account creation). I identified that the charges array was sending raw Date objects instead of the required string format, which caused the API 400 error.

I have submitted a fix in PR #3055 that resolves this by applying dateUtils.formatDate to the dueDate and feeOnMonthDay fields.

Verified locally: Savings Accounts with charges can now be created successfully.

[gkbishnoi07]

i moved your PR here link to solve some issues, thanks for the PR