Skip to content

WEB-339 replace custom api of share.service.ts#2699

Closed
JaySoni1 wants to merge 3 commits intoopenMF:openapi-integrationfrom
JaySoni1:WEB-339-replace-custom-api-of-share-service-ts
Closed

WEB-339 replace custom api of share.service.ts#2699
JaySoni1 wants to merge 3 commits intoopenMF:openapi-integrationfrom
JaySoni1:WEB-339-replace-custom-api-of-share-service-ts

Conversation

@JaySoni1
Copy link
Copy Markdown
Contributor

@JaySoni1 JaySoni1 commented Oct 5, 2025

Replaced custom methods in *.ts files that were previously using ShareService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JaySoni1
Copy link
Copy Markdown
Contributor Author

JaySoni1 commented Oct 5, 2025

@gkbishnoi07 Please Review .

@gkbishnoi07
Copy link
Copy Markdown
Collaborator

@gkbishnoi07 Please Review .

on it!

@steinwinde
Copy link
Copy Markdown
Collaborator

@gkbishnoi07 , are you still reviewing? Or can this be merged?

Copy link
Copy Markdown
Collaborator

@gkbishnoi07 gkbishnoi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Unable to create share account.

@JaySoni1
Copy link
Copy Markdown
Contributor Author

JaySoni1 commented Nov 4, 2025

Ok @gkbishnoi07 I will update the PR soon

@JaySoni1 JaySoni1 force-pushed the WEB-339-replace-custom-api-of-share-service-ts branch from 1e89f45 to b0eb5b8 Compare November 5, 2025 21:11
@JaySoni1
Copy link
Copy Markdown
Contributor Author

JaySoni1 commented Nov 5, 2025

@gkbishnoi07 I have updated the PR please review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2025

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions Bot added the Stale label Dec 6, 2025
@JaySoni1
Copy link
Copy Markdown
Contributor Author

@gkbishnoi07 I have a few doubts regarding this PR, so I have messaged you on Slack. Please check

@github-actions github-actions Bot removed the Stale label Dec 18, 2025
@JaySoni1 JaySoni1 requested a review from gkbishnoi07 December 18, 2025 19:37
@github-actions
Copy link
Copy Markdown

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions Bot added the Stale label Jan 18, 2026
@IOhacker
Copy link
Copy Markdown
Contributor

@gkbishnoi07 @JaySoni1 just doing the follow up on this item.

@github-actions github-actions Bot removed the Stale label Jan 24, 2026
@gkbishnoi07
Copy link
Copy Markdown
Collaborator

@IOhacker i will review it by today

@IOhacker
Copy link
Copy Markdown
Contributor

very appreciated @gkbishnoi07 !!!

@gkbishnoi07
Copy link
Copy Markdown
Collaborator

this PR moved to #3140 to solving some issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants