WEB-339 replace custom api of share.service.ts#2699
WEB-339 replace custom api of share.service.ts#2699JaySoni1 wants to merge 3 commits intoopenMF:openapi-integrationfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
|
@gkbishnoi07 Please Review . |
on it! |
|
@gkbishnoi07 , are you still reviewing? Or can this be merged? |
|
Ok @gkbishnoi07 I will update the PR soon |
1e89f45 to
b0eb5b8
Compare
|
@gkbishnoi07 I have updated the PR please review |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
@gkbishnoi07 I have a few doubts regarding this PR, so I have messaged you on Slack. Please check |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
@gkbishnoi07 @JaySoni1 just doing the follow up on this item. |
|
@IOhacker i will review it by today |
|
very appreciated @gkbishnoi07 !!! |
…-share-service-ts
…-share-service-ts
|
this PR moved to #3140 to solving some issues |

Replaced custom methods in *.ts files that were previously using ShareService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.