fix: in Boost 1.90.0, sha1 digest_type is a byte array - #7
Open
dvnrrs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Boost change the digest_type of Boost.UUID's SHA1 calculation to a byte array. Previously, it was an array of 32-bit words. With the older code, it was necessary to byte-swap the 32-bit words before base64 encoding; with the new code, the digest bytes can be used directly.
The symptom of this problem is generating an incorrect Sec-WebSocket-Accept response header, and strict clients (such as web browsers, Postman, etc.) reporting an invalid key during the WebSocket upgrade handshake.