fix: best-effort max storage on docker backend#27
Open
westbrook-ai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
dockerbackend silently ignored thestoragefield.provision()wired upimage,memory_limit,cpu_limit, andenv, but never readstorage— so per-policystorageandTERMINALS_MAX_STORAGEhad no effect on Docker (Kubernetes already sized PVCs correctly).This wires
storageinto the container via Docker'sStorageOpt, capping the writable layer. Because not every storage driver supports quotas (e.g. overlay2-on-ext4), provisioning falls back gracefully. If the daemon rejects the quota, it logs a warning and retries without it instead of failing.Caveat documented in the README:
StorageOptlimits only the container's writable layer, not the bind-mounted/home/userwhere user files persist (Docker can't quota a bind mount). For hard per-user storage caps, use a Kubernetes backend.terminals/backends/docker.py— applyStorageOptfromstorage, with retry-without-quota fallbackREADME.md— note on Docker storage-limit behavior and its limitsVerified end-to-end against a live Docker daemon: quota applied (
StorageOpt={'size': ...}confirmed via inspect), absent when unset, and fallback retries cleanly on rejection.Related Issues
Fixes #23
Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.