Add guidance for custom samplers #8756
Open
+175
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
vitorvasc
force-pushed
the
custom-samplers-clean
branch
from
86fbd5e to
65aab39
Compare
Member
|
/fix:refcache |
Member
|
/cc @open-telemetry/go-approvers PTAL! |
Contributor
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contribution guidelines,
including the First-time contributing? note.
the
Generative AI Contribution Policy.
This PR adds a new "Custom samplers" section to the Go sampling documentation that provides guidance on creating custom samplers.
The current documentation only covers built-in samplers and lacks guidance on:
How to implement the Sampler interface
How SamplingResult should be handled to ensure correct context propagation
The critical importance of preserving tracestate from the parent span
This is especially important because an incorrectly implemented custom sampler can break distributed tracing by dropping or modifying tracestate and baggage.
Fixes:
Closes #7558