Added a new subsection configuring certificates in the configuration …#8692
Conversation
…file Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
tiffany76
left a comment
There was a problem hiding this comment.
@open-telemetry/collector-approvers, PTAL. Thanks.
jade-guiton-dd
left a comment
There was a problem hiding this comment.
The explanation seems good, if a bit redundant, especially since there are already examples here
Thanks for the feedback — that makes sense 👍 I took another look at this section alongside the existing configtls README, and I agree there’s some overlap in terms of explanations and examples. My initial intent was to make this document self-contained, but I see how that can become redundant given the dedicated TLS docs. One possible approach could be to trim this section down to:
That said, I’m happy to align with whatever level of detail you think is appropriate for this doc. Let me know if you’d prefer a more concise version that defers to the existing TLS documentation, and I can update it according |
|
I think this is fine as-is, my only worry would be about the two docs getting out-of-sync, but I doubt configtls will see changes in the short term anyway. |
|
That makes sense — thanks for the clarification. |
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
|
/fix:refcache |
|
✅ |
…file Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
72084a6 to
6956a41
Compare
|
/fix:refcache |
|
✅ |
|
/fix:all |
|
ℹ️ |
|
/fix:refcache |
|
✅ |
vitorvasc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking this one, @pratik-mahalle.
@tiffany76 @jade-guiton-dd let me know if there are any further comments. Otherwise, we can merge it. 🙂
contribution guidelines,
including the First-time contributing? note.
the
Generative AI Contribution Policy.
Changes Made
Added a new subsection "Using certificates in the Collector" after the certificate generation steps, which includes:
TLS configuration for receivers (server-side) - Shows how to configure
cert_fileandkey_filefor the OTLP receiver to encrypt incoming connectionsTLS configuration for exporters (client-side) - Shows how to configure
ca_fileto verify the server's certificate, and optionallycert_file/key_fileto present a client certificatemTLS configuration (mutual TLS) - Demonstrates how to set up mutual authentication where:
client_ca_fileto verify client certificatesCommon TLS settings table - A reference table with all available TLS configuration options:
ca_file,cert_file,key_file,client_ca_fileinsecure,insecure_skip_verifymin_version,max_versionreload_intervalLink to configtls documentation - Points to the official Go package documentation for more details
Closes: #8003