Handle HTTP 2XX responses as successful in OTLP exporters#2044
Open
vivekmiyani wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Handle HTTP 2XX responses as successful in OTLP exporters#2044vivekmiyani wants to merge 4 commits intoopen-telemetry:mainfrom
vivekmiyani wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
vivekmiyani
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
|
@vivekmiyani we at https://github.com/getsentry/sentry-ruby/ would also like to see this land, but not just for logs exporter but also for traces and metrics exporters. |
Author
|
I agree, this needed to be updated in traces and metrics too which I just did. I'm waiting for maintainers response. ping @arielvalentin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2043.