fix(trace): Fix TraceState vendor-id length validation to match W3C spec#5173
Open
64johnlee wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(trace): Fix TraceState vendor-id length validation to match W3C spec#517364johnlee wants to merge 1 commit intoopen-telemetry:mainfrom
64johnlee wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
The W3C Trace Context spec defines vendor-id as:
vendor-id = lcalpha 0*14( key-chars )
This allows up to 15 characters (1 lcalpha + up to 14 key-chars),
but the previous regex only allowed 14 (lcalpha + 13 key-chars).
Also fix the vendor portion from {0,13} to {0,14} to match the spec.
Fixes open-telemetry#5136.
Signed-off-by: John Lee <john.lee.64john@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The W3C Trace Context spec defines vendor-id as
lcalpha 0*14( key-chars ), allowing up to 15 characters.The previous regex
{0,13}only allowed 14 characters. This PR fixes the vendor-id length validation to match the W3C spec.Fixes #5136.