Replace FIXME for flags value in ExponentialHistogram aggregation#4964
Open
chimchim89 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Replace FIXME for flags value in ExponentialHistogram aggregation#4964chimchim89 wants to merge 1 commit intoopen-telemetry:mainfrom
chimchim89 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
|
I would want to wait to resolve this comment until #4916 is merged in. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the two
FIXME: Find the right value for flagscomments in_ExponentialBucketHistogramAggregation.collect()inopentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py.Per the OpenTelemetry proto spec,
flagsis a bitmask where0means no flags are set. The only other defined value is DATA_POINT_FLAGS_NO_RECORDED_VALUE_MASK = 1, which represents a no-recorded-value condition. These code paths are only reached when a recorded value exists, soflags=0` is correct. The comments have been updated to explain this.Type of change
How Has This Been Tested?
This change only updates comments, no logic was changed. Verified with:
tox -e linttox -e precommitDoes This PR Require a Contrib Repo Change?
Checklist: