Enable ruff pyupgrade (UP) lint rules#4940
Enable ruff pyupgrade (UP) lint rules#4940toroleapinc wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
@toroleapinc thanks for the PR we can accept contributions only if you sign the CLA |
Enable a subset of pyupgrade rules that are safe for the Python 3.8 target version: - UP011: lru-cache-without-parameters - UP015: redundant-open-modes - UP032: f-string (replaces .format() calls) - UP034: extraneous-parentheses - UP037: quoted-annotation (removes unnecessary string quotes) All 42 violations were auto-fixed by ruff. Part of open-telemetry#4227 Signed-off-by: edvatar <88481784+toroleapinc@users.noreply.github.com>
40895e2 to
a79066b
Compare
|
Thanks @toroleapinc ! Please do these and push the fixes:
|
|
Thanks for the contribution! Just curious, what was the thought-process behind choosing these specific ruff rules or is this arbitrary? |
|
@lzchen These weren't arbitrary — I picked the rules that had the most existing violations in the codebase to get the biggest cleanup in one pass:
I deliberately left out the more disruptive UP rules (like UP007 for |
|
@tammy-baylis-swi Ran both — |
No need, the separation makes sense. As long as we have a documented set of supported/supported SGTM. |
Summary
Enable a subset of safe pyupgrade (
UP) ruff rules that are compatible with the Python 3.8 target version:UP011: Remove unnecessary parentheses from@lru_cache()UP015: Remove redundantopen()mode argumentsUP032: Replace.format()calls with f-stringsUP034: Remove extraneous parenthesesUP037: Remove unnecessary quoted annotations (in files withfrom __future__ import annotations)All 42 violations were auto-fixed by
ruff check --fix.Not included (unsafe for py38 target): UP006, UP007, UP031, UP045 which require Python 3.9+/3.10+ syntax.
Part of #4227