fix(opamp-client): add missing requests dependency - #4930
Open
theycallmeloki wants to merge 2 commits into
Open
Conversation
Signed-off-by: Loki San <ogmiladyloki@gmail.com>
pmcollins
approved these changes
Aug 6, 2026
pmcollins
left a comment
pmcollins
left a comment
Member
There was a problem hiding this comment.
Needs changelog tweak but otherwise LGTM.
Signed-off-by: Loki San <ogmiladyloki@gmail.com>
Author
|
Done: renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(opamp-client): add missing requests dependency
Fixes #4929
opentelemetry._opamp.transport.requestsimports therequestspackage butpyproject.tomlnever declared it, soimport opentelemetry._opamp.clientraised
ModuleNotFoundErrorin a fresh environment.Adds
requests ~= 2.0to the dependencies (same pin asopentelemetry-instrumentation-requests).Verified: fresh venv install of the package now imports cleanly.